mysqli native driver - enable mysql-8.0#6127
Closed
grooverdan wants to merge 3 commits intophp:PHP-7.3from
Closed
Conversation
Tested with: * mysql-5.6.49-linux-glibc2.12-x86_64 * mysql-5.7.31-linux-glibc2.12-x86_64 * mysql-8.0.21-linux-glibc2.17-x86_64 * mariadb-10.5.6 configure --with-mysqli=/usr/local/$version/bin/mysql_config --with-pdo-mysql=/usr/local/$version MySQL-8.0 removed my_bool Some options where deprecated in mysql-8.0 MY_CHARSET_INFO used with exposed api mysql_get_character_set_info rather than internal structures.
MySQL-8.0 removes option MYSQLI_OPT_SSL_VERIFY_SERVER_CERT
The mysqlclient_r library exists in mysql-5.6 for compatibility only. Later versions have it removed.
nikic
approved these changes
Sep 17, 2020
Member
nikic
left a comment
nikic
left a comment
There was a problem hiding this comment.
This looks good to me. The >= 80000 < 100000 checks are not great and might be better replaced by some configure detection, but let's go with it for now.
Member
|
I've merged these changes into PHP-7.3 and up. I've also applied an additional fix (e7f98f8) to get things to build on master as well. |
Contributor
Author
|
Thanks @nikic . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
my_global.h wasn't intended as a client library consumable header. MySQL-8.0 removes it.
MY_CHARSET_INFO was a usable alternate over using the server side definition of CHARSET_INFO
With a few minor changes, MySQL-5.6 -> MySQL-8.0 all compile with these changes.
Combined with the extended test suite of #6126, results in https://travis-ci.org/github/grooverdan/php-src/jobs/726727625