Fix #78792: zlib.output_compression disabled by Content-Type: image/#6198
Closed
cmb69 wants to merge 1 commit intophp:masterfrom
Closed
Fix #78792: zlib.output_compression disabled by Content-Type: image/#6198cmb69 wants to merge 1 commit intophp:masterfrom
cmb69 wants to merge 1 commit intophp:masterfrom
Conversation
Disabling output compression for images has served to fix bug php#16109, where zlib compressed images apparently have caused issues with Navigator 4. This shouldn't be an issue with somewhat contemporary browsers. Other than that, this is an arbitrary restriction – why don't we disable the compression for some other media types as well (e.g. video/* and audio/*)? All in all, we should leave that decision to userland.
Member
Author
|
Oh, should not forget to credit Ewgenij Starostin who contributed the patch. |
nikic
approved these changes
Sep 29, 2020
Member
nikic
left a comment
nikic
left a comment
There was a problem hiding this comment.
Please also add an UPGRADING note for this one. I think most of the time you indeed want to disable compression for images, but it is something we should leave under the control of the user. This only affects images served through PHP, and zlib.output_compression can be modified at runtime.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disabling output compression for images has served to fix bug #16109,
where zlib compressed images apparently have caused issues with
Navigator 4. This shouldn't be an issue with somewhat contemporary
browsers. Other than that, this is an arbitrary restriction – why
don't we disable the compression for some other media types as well
(e.g. video/* and audio/*)? All in all, we should leave that decision
to userland.