Fix #80152: odbc_execute() moves internal pointer of $params#6219
Closed
cmb69 wants to merge 1 commit intophp:PHP-7.3from
Closed
Fix #80152: odbc_execute() moves internal pointer of $params#6219cmb69 wants to merge 1 commit intophp:PHP-7.3from
cmb69 wants to merge 1 commit intophp:PHP-7.3from
Conversation
As least intrusive fix, we separate the passed array argument.
Member
Author
|
The AppVeyor failure is unrelated (flaky test). |
nikic
approved these changes
Sep 29, 2020
Member
nikic
left a comment
There was a problem hiding this comment.
LG. Using ZEND_HASH_FOREACH_VAL is definitely preferred for master, but isn't your suggested diff missing some kind of check that the array has sufficient elements? That is, the "Error getting parameter" error condition seems to get lost.
Member
Author
|
There is already a check immediately before the loop: Lines 1327 to 1329 in f6cda06 Isn't that sufficient? |
Member
|
@cmb69 Ah yes, that does look sufficient. |
Member
Author
|
"master" improved with a6ecafe. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As least intrusive fix, we separate the passed array argument.
For the "master" branch, the following fix seems to be preferable: