Fix #80186: Prevent segfault when iterating FFI obj props#6270
Closed
adsr wants to merge 1 commit intophp:masterfrom
Closed
Fix #80186: Prevent segfault when iterating FFI obj props#6270adsr wants to merge 1 commit intophp:masterfrom
adsr wants to merge 1 commit intophp:masterfrom
Conversation
Member
|
Member
|
Looking at this code, we probably should also add some fast-path skips for empty arrays in more places, as currently we'll end up allocating a new copy of an empty array, just to free it again right away. But that's a separate issue... |
Member
|
I've landed a fix in 15443f8 that does the aforementioned check for empty arrays. |
Contributor
Author
|
Thanks @nikic Can you add a |
Member
|
Sure, done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.php.net/bug.php?id=80186