fixed and rebased

+1 please, php-fpm is the last component in our internal network that does not support ipv6, we would love to kill ipv4 internally :)

Yes I agree; we have the exact same problem. Everything runs over ipv6 but our firewalls need to make 1 exception because fpm cannot handle ipv6. The only alternative is running an instance of socat to convert ipv6 to ipv4....

+1000 this would kill the last IPv4 dep

+1!
IPv6 support would be really really nice!

Yes please!

Is somebody going to take a look at this before PHP 5.6?

💯

What happens when one enters only port? Will it listen on both IPv4 and IPv6?

Ping @Tyrael, what do you think? Possible for 5.6?

We are too deep into the release release (we already had an RC2, feature freeze since beta1) to have this in 5.6, but we I would like to see this in master. Sorry that we missed this, I will try to do a better job with keeping up with the pull requests, but if you see an rfc not getting the deserved attention, feel free to drop a reminder email to [email protected]

@Tyrael This looks like a minor, self-contained feature addition. Can't we add that in 5.6.1? Unless I misunderstand the impact, this could also go to 5.5.

@nikic it is a possibility for 5.6.1. for 5.5 we should ask @jpauli

Bump.

We are too deep into the release release (we already had an RC2, feature freeze since beta1) to have this in 5.6, but we I would like to see this in master.

Surprisingly, this can be added in RC4: "Add SO_REUSEPORT + SO_BROADCAST support via socket stream context option" a51bf0c

No references to a pull request, bug report or whatsoever. An individual PHP develeoper with git access can do whatever they want. A pull request for IPv6 support which should have been added 5 years ago, with multiple votes and issues on bugs.php.net cannot be merged "because of feature freeze".

Strange...

indeed this is pretty absurd...

I'm all right to have this added to 5.5

@arjenschol Thanks for catching this, I've just sent an email to the author to revert
it, since we are in feature freeze since beta1.

+1 lets get rid of legacy IP.

Now 5.6.0 is released, can this be pulled into the 5.6 branch for release in 5.6.1?

From the thread above it seems you should have it into 5.5 and merge it
into 5.6...

On Fri, Aug 29, 2014 at 12:01 PM, Arjen [email protected] wrote:

Now 5.6.0 is released, can this be pulled into the 5.6 branch for release
in 5.6.1?

—
Reply to this email directly or view it on GitHub
#631 (comment).

let me ping @Tyrael and @jpauli about this, hope we can finally make it!

I would be fine having this in 5.6.1, as it shouldn't have any impact for existing fpm deployments, but people can opt-in to listen on the v6 address with the new config option.
@jpauli what do you think about having it in 5.5?

Yes sure, it can go to 5.5 as well

Meanwhile, some more features are being added to 5.6.1.. But not this patch.

With 5.6.1 now RC1, guess we have to wait at least another month..

this must be a joke or something...

@jpauli so what are we waiting for merging this?

This is sad. So much ignorance... 😟

Also, noone yet answered my question:

What happens when one enters only port? Will it listen on both IPv4 and IPv6?

@Majkl578 i can't guarantee that without testing it but looking at the code it should open connections for both ipv4 and ipv6 if you only set the port :)

Bump again, ping @Tyrael + @jpauli. This is really getting awkward...

@acasademont: Thanks, that's how it should work, I was just curious whether the implementation is aware of that. :)

Bump.

Seems like it's time for PHP 5.6.2 merges :p

@Tyrael @jpauli please do not forget this one, thanks!

hi, I've merged the patch into 5.5 and upwards.
squashed the three commits into a single one, but kept you as the author.
thanks for the contribution, and sorry that it took this long to get it merged.

Wow, great.Thanks!

thank you all! this is awesome news :D

@jpauli @Tyrael in PHP 5.5.18 this PR was finally pulled off and added for 5.5.19 but the NEWS file states that this appeared on 5.5.18 which may lead to confusion. Could that line be added to the 5.5.19 changelog? Thanks!!

Hey @globin , I consistently see sapi/fpm/tests/003.phpt fails with:

Warning: fsockopen(): php_network_getaddresses: getaddrinfo failed: Address family for hostname not supported in /home/huixinchen/opensource/trunk/sapi/fpm/tests/003.php on line 24

This change (or another FPM related change in version 5.5.19 and 5.6.3) seems to break PHP-FPM when using the network stack. It can be reproduced e.g. on Ubuntu 14.04 by creating 5 different pools (port numbers 9001 to 9005) and then starting the PHP-FPM service. I would expect to have a listener on each of the five ports, instead only the first pool is actually loaded. The others fail to load (can e.g. be checked with netstat -tlpn | sort).

I had to downgrade to version 5.5.18/5.6.2 to fix the issue.

@leofeyer I have reported a similar bug for that @ https://bugs.php.net/bug.php?id=68420. I don't think posting bugs in the comments of PR is a good idea

@SjonHortensius Thanks, but this bug seems to handle a different issue, so I have created a separate one: https://bugs.php.net/bug.php?id=68423