Hi, it fixes same mem leaks but not all. The openssl_open need to be changed to address all cases. There are RETURN_FALSE that can result in memory leak. It should be changed to RETVAL_FALSE and then do the final clean up. Look to the openssl_encrypt. It would be probably best to do it similar way...

Thanks for the suggesiton. I'll clean up that section of code a bit more to cover all cases.

replace RETURN_FALSE by RETVAL_FALSE, RETURN_TURE by RETVAL_TRUE in a few places such that I can move cleanup code to the end of the function, and remove a couple of duplicate if blocks as well.

I see in the tests this:

TEST 5193/12224 [ext/openssl/tests/002.phpt]
========DIFF========
002+ Segmentation fault

Which is not good. Looks like the patch is not right.

@smalyshev Thanks for pointing that out. I missed one corner case. I'll get a fix soon and pay more attention to the Travis CI build.

Ok. My previous commit fixed that test in [ext/openssl/tests/002.phpt]. Travis CI build failed from other reasons.

Because the normal workflow is already tested in [ext/openssl/tests/013.phpt], I don't add a new test case.

Comment on behalf of stas at php.net:

merged