Thanks for the PR! However, for the stable branches (7.3 and 7.4) I'd prefer to define U_DEFINE_FALSE_AND_TRUE (either via config.m4 or in the sources before any ICU header is included). For 8.0/master I'd prefer to no longer use TRUE and FALSE at all.

@sgolemon, what do you think?

However, for the stable branches (7.3 and 7.4) I'd prefer to define U_DEFINE_FALSE_AND_TRUE

All right, I'll try that.

For 8.0/master I'd prefer to no longer use TRUE and FALSE at all.

What would be the alternative? Use 1 and 0 literals instead?

I've added the setting to PHP_SETUP_ICU in acinclude.m4. Is that the right spot?

What would be the alternative? Use 1 and 0 literals instead?

We're requiring C99 for 8.0/master anyway, so we could use true and false.

I've added the setting to PHP_SETUP_ICU in acinclude.m4. Is that the right spot?

Not quite sure. I'm mostly working on Windows, and there, TRUE and FALSE are already defined by some Windows header file, and as such ICU 68.1 appears to run fine without any changes.

Thank you for merging.

We're requiring C99 for 8.0/master anyway, so we could use true and false.

I see. I'll work on a PR when this change has been merged to PHP-8.0.

I see. I'll work on a PR when this change has been merged to PHP-8.0.

Nikita already did that. :)

Since this PR has been merged into PHP-7.3, it may make sense to backport 77b6e95 as well.

If you have the time, could you please backport PHP 7.2 ?

@TAKI PHP 7.2 is EOL and won't be patched anymore. But you can simply set those CFLAGS locally yourself when compiling PHP 7.2 and it should work. Homebrew for instance does just that:

https://github.com/Homebrew/homebrew-core/blob/8c20c466845d263b9d63ceab484805eb86136268/Formula/php%407.2.rb#L67-L69

Hello all, I have same issue and Abel to fix the icu4c 68.2 or revert to 67.1. Any help?

I understood I have to add this -> ICU_CFLAGS="$ICU_CFLAGS -DU_DEFINE_FALSE_AND_TRUE=1", but not clear where