Fixed Bug #61785 (Memory leak when access a non-exists file without route)#64
Closed
reeze wants to merge 2 commits intophp:PHP-5.4from
Closed
Fixed Bug #61785 (Memory leak when access a non-exists file without route)#64reeze wants to merge 2 commits intophp:PHP-5.4from
reeze wants to merge 2 commits intophp:PHP-5.4from
Conversation
Member
|
hmm, seems I replied to wrong pull request, heh, I meant this one is a good catch, I will look into this in the weekend, thanks |
Member
|
thanks for spotting this out, but sorry to say, I have committed a better fix. |
|
Comment on behalf of laruence at php.net: closed |
Contributor
Author
|
Seems you remove capturing... why now? On 21 April 2012 00:05, Xinchen Hui <
|
Member
|
because the new solution is not heavy anymore than ob_buffer. |
EdmondDantes
added a commit
to true-async/php-src
that referenced
this pull request
Oct 1, 2025
…ead of warnings
- Add new Async\DeadlockError exception class extending Error
- Replace multiple async_warning() calls with single structured exception
- Implement proper exit_exception handling for inter-coroutine safety
- Update resolve_deadlocks() to set ZEND_ASYNC_EXIT_EXCEPTION correctly
- Add ZEND_ASYNC_EXCEPTION_DEADLOCK to async class enum (ID: 36)
- Extend async_get_class_ce() to support new exception type
- Update all deadlock tests to expect exception instead of warnings
- Fix memory leak by removing unnecessary GC_ADDREF calls
This change improves error handling by providing a single, catchable
DeadlockError exception instead of multiple warnings, while maintaining
proper coroutine cancellation behavior through exit_exception mechanism.
Tests updated:
- 001-deadlock-basic-test.phpt
- 002-deadlock-with-catch.phpt
- 003-deadlock-with-zombie.phpt
- 010-deadlock-after-cancel-with-zombie.phpt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@https://bugs.php.net/bug.php?id=61785
When access a non exists file in builtin web server. with --enable-debug it report
leaks.
When send error page, It call php_output_deactivate() it disabled the sent_headers
callback but it will emalloc default_content-type. then it leaks.
So I think set SG(sapi_headers).send_default_content_type to 0 temporary can avoid
leaking.
BTW: I fixed a typo in test file.
Xinchen @laruence will you take a look at this fix?
Thanks.