Fix #80366: Return Value of zend_fstat() not Checked#6432
Closed
cmb69 wants to merge 1 commit intophp:PHP-7.4from
Closed
Fix #80366: Return Value of zend_fstat() not Checked#6432cmb69 wants to merge 1 commit intophp:PHP-7.4from
cmb69 wants to merge 1 commit intophp:PHP-7.4from
Conversation
In the somewhat unlikely case that `zend_fstat()` fails, we must not proceed executing the function, but return `false` instead. Patch based on the patch contributed by sagpant at microsoft dot com.
nikic
approved these changes
Nov 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the somewhat unlikely case that
zend_fstat()fails, we must notproceed executing the function, but return
falseinstead.Patch based on the patch contributed by sagpant at microsoft dot com.