That is analogous to what GMP does, but in my opinion, it would be beneficial to have a dedicated function to verify the validity of a number given as string. Also, I think a ValueError would be more appropriate than a TypeError.

@cmb69 I will change it to a value error, that indeed looks more appropriate.

There's a function called php_str2num in the bcmath.c file, or would you like to have a globally accessible function?

I will change it to a value error, that indeed looks more appropriate.

I'd rather be consistent with GMP. @Girgias, since you promoted to TypeError, what do you think? /cc @nikic

There's a function called php_str2num in the bcmath.c file, or would you like to have a globally accessible function?

Yes, this was about a function which could be called from userland. And that function should just return true or false, similar to is_numeric(). Anyhow, a new function should likely have its own PR.

I think a ValueError would be better, not exactly sure why I did a TypeError for GMP, but I need to possibly tweak some things with GMP anyway.

Would it be possible to use the version with the argument number (IIRC zend_argument_value_error()) ? As this is usually better IMHO.

Would it be possible to use the version with the argument number (IIRC zend_argument_value_error()) ?

That would require to pass the arg num to php_str2num(), but that shouldn't be an issue.

@cmb69 @Girgias I changed the TypeError to a ValueError and I've used the zend_argument_value_error variant.

Not sure why the CI failed.

I think that CI failure is unrelated to this PR.

@nikic Thanks, I changed the return type from void to zend_result and moved the value error to the functions itself. I also added the early returns for the other functions in this file. Also noticed some empty returns at the end of some functions, I removed those as they seem unnecessary. The tests still pass locally.

@nikic I've pointed this PR to the PHP-8.0 branch, is that correct?

I merged this as 94a151a a while ago, but messed up the auto-close tag.