Fix Bug #80560: Strings containing only a base prefix return 0 object#6549
Closed
Girgias wants to merge 1 commit intophp:PHP-8.0from
Closed
Fix Bug #80560: Strings containing only a base prefix return 0 object#6549Girgias wants to merge 1 commit intophp:PHP-8.0from
Girgias wants to merge 1 commit intophp:PHP-8.0from
Conversation
cmb69
approved these changes
Dec 29, 2020
Member
cmb69
left a comment
cmb69
left a comment
There was a problem hiding this comment.
Given that passing an empty string is an error, it makes sense to disallow this as well. I agree that the fix should target 8.0+.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Targets PHP 8.0 as this is long standing behaviour and not sure if it's worth to fix in PHP 7.4, as it's also a BC breaking change.