Fix #74779: x() and y() truncating floats to integers#6665
Closed
cmb69 wants to merge 2 commits intophp:PHP-7.4from
Closed
Fix #74779: x() and y() truncating floats to integers#6665cmb69 wants to merge 2 commits intophp:PHP-7.4from
cmb69 wants to merge 2 commits intophp:PHP-7.4from
Conversation
We must not use the locale dependent `atof()`, but instead use the (hopefully) locale independent `zend_strtod()`, when converting string representations of floating point numbers which are sent by the server.
nikic
approved these changes
Feb 4, 2021
Member
nikic
left a comment
nikic
left a comment
There was a problem hiding this comment.
Looks like there are also uses of atof in pgsql.c, though only for version comparison.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We must not use the locale dependent
atof(), but instead use the(hopefully) locale independent
zend_strtod(), when converting stringrepresentations of floating point numbers which are sent by the server.
According to the documentation there is no way to change
LC_NUMERICfor the server, so we can expect the server to always sent string representations of floating point numbers with a dot as decimal separator. I'm not sure about that, though, particularly wrt. the MySQL forks.Also, if
zend_strtod()is built withUSE_LOCALEdefined, we're back at square one. I think we can ignore that possibility, though, since it likely would break other stuff as well.