Fix #80460: ODBC doesn't account for SQL_NO_TOTAL indicator#6809
Closed
cmb69 wants to merge 1 commit intophp:PHP-7.4from
Closed
Fix #80460: ODBC doesn't account for SQL_NO_TOTAL indicator#6809cmb69 wants to merge 1 commit intophp:PHP-7.4from
cmb69 wants to merge 1 commit intophp:PHP-7.4from
Conversation
The `StrLen_or_IndPtr` parameter usually may be `SQL_NO_TOTAL`; we need to cater to that possibility to avoid working with negative string lengths and other issues. A noteable exemption are calls to `SQLGetData()` which return `SQL_SUCCESS`; in that case `SQL_NO_TOTAL` can not occur.
Member
Author
|
Would be nice to have some tests for this behavior, but I don't have a driver at hand which exhibits the reported behavior, and likely it couldn't be tested in CI anyway, so I'm opening this for review. |
Member
Author
|
Going to re-open right away to trigger CI (old CI results are gone). |
Member
Author
|
Okay, the new CI jobs have been green, and I don't think there'll be somebody coming up with a regression test, so I'm going to apply this PR ASAP. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
StrLen_or_IndPtrparameter usually may beSQL_NO_TOTAL; we needto cater to that possibility to avoid working with negative string
lengths and other issues. A noteable exemption are calls to
SQLGetData()which returnSQL_SUCCESS; in that caseSQL_NO_TOTALcan not occur.
Marked as draft, because I'm hoping to get at least a test case for the behavior from the bug reporter.