Fix #79812: Potential integer overflow in pcntl_exec()#6845
Closed
cmb69 wants to merge 3 commits intophp:PHP-7.4from
Closed
Fix #79812: Potential integer overflow in pcntl_exec()#6845cmb69 wants to merge 3 commits intophp:PHP-7.4from
cmb69 wants to merge 3 commits intophp:PHP-7.4from
Conversation
We use the proper type.
Member
|
The length addition can still overflow, I'd suggest to use safe_emalloc. |
We can assume that neither string length is `SIZE_MAX`, and then use `safe_emalloc()` to ensure that the addition does not overflow.
Member
Author
|
Oh, right; better safe than sorry. |
nikic
approved these changes
Apr 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We use the proper type.