Remove the "getdir" function which was introduced accidentally#6855
Closed
IMSoP wants to merge 1 commit intophp:PHP-8.0from
Closed
Remove the "getdir" function which was introduced accidentally#6855IMSoP wants to merge 1 commit intophp:PHP-8.0from
IMSoP wants to merge 1 commit intophp:PHP-8.0from
Conversation
The actual name of this function is dir(), but ever since it was introduced in PHP 3, its internal name was "getdir", leading to it being mistaken for an alias. This went unnoticed until the switch to stubs for generating arginfo, at which point getdir() became a real but undocumented function. Fixes bug #80914
kocsismate
approved these changes
Apr 11, 2021
IMSoP
force-pushed
the
remove-accidental-getdir
branch
from
4e441b1 to
3ccfe6f
Compare
nikic
approved these changes
Apr 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The actual name of this function is dir(), but ever since it was
introduced in PHP 3, its internal name was "getdir", leading to it
being mistaken for an alias. This went unnoticed until the switch
to stubs for generating arginfo, at which point getdir() became a
real but undocumented function.