Fix #73246: XMLReader: encoding length not checked#6899
Fix #73246: XMLReader: encoding length not checked#6899cmb69 wants to merge 1 commit intophp:PHP-7.4from
Conversation
libxml2 expects the passed encoding to be NUL terminated, so we reject strings with NUL bytes right away.
nikic
left a comment
There was a problem hiding this comment.
LG, but I don't think this meaningfully addresses bug #73246.
|
Well, the reported stack-overflow looks like an issue in the |
Oh, I do agree that this is not our problem and we shouldn't address it from our side. Just saying that this fix isn't really related to that issue... |
|
Well, would have been better to close that ticket as not a bug, and to open a new one regarding the NUL bytes, but I think it has been okay-ish to "retarget" the ticket. |
libxml2 expects the passed encoding to be NUL terminated, so we reject
strings with NUL bytes right away.