Add simple Firebird payload fake server to test suite#6940
Closed
cmb69 wants to merge 2 commits intophp:PHP-7.4from
Closed
Add simple Firebird payload fake server to test suite#6940cmb69 wants to merge 2 commits intophp:PHP-7.4from
cmb69 wants to merge 2 commits intophp:PHP-7.4from
Conversation
This is meant to test against certain fixed responses of FireBird servers. For now we add just a most basic test which verifies a connection attempt.
We also fix a typo in a comment.
Contributor
|
Didn't test it but the idea looks fine for me, if we have ways to capture correct payloads. |
Member
|
What's the context for this? |
Member
Author
The payload for the test in this patch has been sniffed with Wireshark (a bit fiddly, since suport for gdsdb isn't as good as for mysql, for instance, but doable).
It's mostly about malicious payloads. |
nikic
approved these changes
May 6, 2021
Member
nikic
left a comment
nikic
left a comment
There was a problem hiding this comment.
This looks okay to me. You might want to test it against master, as I don't think we compile PDO firebird on 7.4.
Member
Author
|
CI was fine for PR #6947. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is meant to test against certain fixed responses of FireBird
servers. For now we add just a most basic test which verifies a
connection attempt.