* double fastcgi_end_request on max_children limit#710
Closed
dmitry-saprykin wants to merge 1 commit intophp:PHP-5.5.14from
dmitry-saprykin:double_fastcgi_end_request_fix_5.14
Closed
* double fastcgi_end_request on max_children limit#710dmitry-saprykin wants to merge 1 commit intophp:PHP-5.5.14from dmitry-saprykin:double_fastcgi_end_request_fix_5.14
dmitry-saprykin wants to merge 1 commit intophp:PHP-5.5.14from
dmitry-saprykin:double_fastcgi_end_request_fix_5.14
Conversation
Contributor
Those facts should help pushing that modification into the main trunk... |
Contributor
|
It would be better to close this one and reopen #709 requesting a merge to the |
Member
|
close as we don't accept PR against TAG version. please reopen #709 instead. |
Contributor
Member
|
@Berbe it truned out I can not reopen it.. because the origin branch seems deleted by the author. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Php sends 2 fastcgi FCGI_END_REQUEST records instead of one when
fastcgi_finish_request();called and fpm param max_requests exceeded.fastcgi_finish_request();callfpm_main.c:1951 requests++; if (max_requests && (requests == max_requests)) { fcgi_finish_request(&request, 1); break; }It confuses fastcgi client (i.e. nginx) receiving 2 FCGI_END_REQUEST records one after another.
So I have set
request->closedflag to prevent second FastCGI record sending.