Always consume meridian for correct error reporting#711
Closed
DaveRandom wants to merge 1 commit intophp:PHP-5.6from
Closed
Always consume meridian for correct error reporting#711DaveRandom wants to merge 1 commit intophp:PHP-5.6from
DaveRandom wants to merge 1 commit intophp:PHP-5.6from
Conversation
Contributor
|
This seems to break a unit test: Please look into it. |
Contributor
Author
|
In retrospect, this is not the best way to deal with the underlying problem. I'm closing this for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Always consume meridian data from input string to ensure the correct error is reported in the errors array.
Fix for bug #64975.
Re-submit of #668 because I screwed up my branching.