Fix #78987 - Memory problems running finfo::buffer#7187
Fix #78987 - Memory problems running finfo::buffer#7187davisinfo wants to merge 1 commit intophp:PHP-7.3from
Conversation
|
Thank you for the PR! That doesn't look like a security issue, though, and as such is not eligible for PHP-7.3; the patch should target PHP-7.4. Furthermore, these changes need to be integrated into libmagic.patch. Plus, there should be a regression test. cc @weltling |
|
@cmb69 there was one that targeted PHP-7.4 but @Girgias closed it #7188 From what I saw the libmagic.patch is not used automatically during the compilation but just manually when you use the generate_patch.sh to grab a new version of the source files from the file library This PR only includes the changes specific to this bug, but on master the files were updated to the ones from the latest version of the files, we could do that also if that is desired. |
Okay, so I close this and re-open the other.
Right. It still can make sense to update libmagic.patch, to be able to see what we changed compared to the original version. Not really sure how that has been handled so far. |
Fix #78987 - Memory problems running finfo::buffer