Fix #78987 - Memory problems running finfo::buffer#7188
Closed
davisinfo wants to merge 4 commits intophp:PHP-7.4from
Closed
Fix #78987 - Memory problems running finfo::buffer#7188davisinfo wants to merge 4 commits intophp:PHP-7.4from
davisinfo wants to merge 4 commits intophp:PHP-7.4from
Conversation
Member
|
Duplicate of #7187 |
Member
|
Could you please fix the failing test? |
Author
|
I’ll look into it |
nikic
reviewed
Jun 28, 2021
|
Any news on this? |
Author
|
Sorry, I didn’t forget but it was a busy period. I’ll work on it in the next days. |
Author
Member
|
@weltling, what do you think? |
|
@cmb69 the submitted patch doesn't seem appropriate for 7.4, a test is missing and there's a lot of unrelated white space change. @davisinfo appreciate your efforts to fix this. May i suggest this:
I might have time to fix this closer to next week or alike, there still seems to be room for this change to get into 7.4. Thanks |
|
Backported the upstream solution in fa96c7e. Thanks. |
|
Is this fix in 7.4.24 or not yet in a public 7.4.x release? |
|
To answer my own question: looks like it's in the 7.4.25 release notes! Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #78987 - Memory problems running finfo::buffer