Fix #80833 ZipArchive::getStream doesn't use setPassword#7359
Closed
remicollet wants to merge 4 commits intophp:masterfrom
Closed
Fix #80833 ZipArchive::getStream doesn't use setPassword#7359remicollet wants to merge 4 commits intophp:masterfrom
remicollet wants to merge 4 commits intophp:masterfrom
Conversation
Member
Author
|
Also prepared for pecl ext, https://github.com/pierrejoye/php_zip/tree/issue-80833 |
Member
Author
|
Notice, if the ZipArchive is closed, then the open streams become unusable, but this is properly detected by the library:
|
cmb69
reviewed
Sep 1, 2021
Member
cmb69
left a comment
cmb69
left a comment
There was a problem hiding this comment.
Thank you! That looks much cleaner than my PR.
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Could apply in 7.4+
Previously,
php_stream_zip_openreopen the same archive, bad for perf, and also explain why password is lost.