improve CGI executable path detection for command prefix#7570
Closed
remicollet wants to merge 2 commits intophp:masterfrom
Closed
improve CGI executable path detection for command prefix#7570remicollet wants to merge 2 commits intophp:masterfrom
remicollet wants to merge 2 commits intophp:masterfrom
Conversation
nikic
approved these changes
Oct 12, 2021
Member
nikic
left a comment
nikic
left a comment
There was a problem hiding this comment.
LG assuming it doesn't break CI.
Member
Author
|
No... won't work.... with like php81-php |
Member
Author
|
@nikic seems better.... but probably some cases are still not handled... at least the common ones are ok e.g.
(such cases, like "myphp" suffix, still broken... ) |
Member
|
I liked the previous version more. Supporting |
Member
Author
|
1st way merged as ea00e65 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://bugs.php.net/bug.php?id=81520