Issue 68549: Timezones and offsets are not properly used when working with dates#7639
Issue 68549: Timezones and offsets are not properly used when working with dates#7639ComaVN wants to merge 3 commits intophp:PHP-7.4from
Conversation
ComaVN
changed the title
|
Please submit PRs for ext/date/lib/* to https://github.com/derickr/timelib. |
I'd do that, but I'm having trouble figuring out how... the last commit on PHP-7.4 seems to indicate it's version |
|
timelib is on 2021.10 right now. Still, try to fix it there, and then a back-port of the fix might be viable. |
According to CONTRIBUTING.md, bugfixes are against the lowest branch first, right? and that's definitely not on 2021.10... I'll see what I can do in https://github.com/derickr/timelib |
… for a timezone around and east of UTC
…ing with dates) Particularly when setting timestamps or changing timezones during DST changes
|
I managed to fix it a lot easier, without changing timelib. I still think there's a bug there, it's just not noticable here anymore. |
|
This doesn't look right. The function should be able to be called regardless of whether the sse is up to date |
Well, it clearly cannot. I'm currently busy trying to get an MR working for timelib tho. |
That is derickr/timelib#121. |
|
This PR can be closed, as the relevant code has made it into timelib now and will automatically filter down here when it gets merged. |
3 participants
This is a fix for bug #68549
It's not as clean as I hoped, but it's extensively unit tested
The fix would probably be simpler if the
timelib_time_offsettype also contained the timestamp of the next DST transition, but that seemed like too big of a change to me.