gmp_init(): Don't use leading 0x or 0b if different base specified#799
Closed
plstand wants to merge 1 commit intophp:masterfrom
plstand:bug50175
Closed
gmp_init(): Don't use leading 0x or 0b if different base specified#799plstand wants to merge 1 commit intophp:masterfrom plstand:bug50175
plstand wants to merge 1 commit intophp:masterfrom
plstand:bug50175
Conversation
Fixes bugs #50175 and #55398.
Member
|
This isn't right - if no base is specified (base 0) then hex and binary should be detected. |
Member
|
Now fixed via 834daa4. |
Contributor
Author
|
@nikic, hex, binary, and octal are already detected by GMP itself when base == 0, so that's why I didn't bother checking that. Your version of the patch should still fix the bug, so closing this request. |
Member
|
@plstand You're absolutely right, I wasn't aware of that - thought the code was there to handle the base 0 case. I'll leave the extra comparisons in there for now, so people like myself don't get confused ^^ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes bugs #50175 and #55398.
Made pull request against master; backport to older branches if you wish.
@smalyshev @TazeTSchnitzel @nikic