Merged
Conversation
this fixes a regression from 6c2a806. smart_str_appendl is expecting the length as the length of the string, but key_length is the byte length of the key, including the 0 terminator. As such, the cookie name appeneded to the header would now also include the 0 terminator of the key name which then would be sent to the server.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this fixes a regression from 6c2a806
which caused bug 67955:
smart_str_appendlis expecting the length as the length of the string,but key_length is the byte length of the key, including the 0
terminator.
As such, the cookie name appended to the header would now also include
the 0 terminator of the key name which then would be sent to the server.