Use ASCII delimiters for browscap regular expressions#827
Closed
datibbaw wants to merge 2 commits intophp:PHP-5.4from
Closed
Use ASCII delimiters for browscap regular expressions#827datibbaw wants to merge 2 commits intophp:PHP-5.4from
datibbaw wants to merge 2 commits intophp:PHP-5.4from
Conversation
Replaced expression delimiter with tilde (~) and escape where necessary.
|
👍 Coming from my report at: https://bugs.php.net/bug.php?id=68021 When will this go out? Thanks. |
|
@datibbaw the change looks fine, it's almost cosmetic. But in the ticket they mention it breaks json, so maybe it'd make sense to add a test for that? |
|
Any update on this? When will this ship? We are running 5.4.34. |
Contributor
|
merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes bug 68012.
Uses the tilde as the expression delimiter to make them ASCII compatible instead of
\xA7.