Skip to content

LMDB Support for driver flags#8892

Merged
Girgias merged 4 commits intophp:masterfrom
Girgias:dba-lmdb-flags
Jul 23, 2022
Merged

LMDB Support for driver flags#8892
Girgias merged 4 commits intophp:masterfrom
Girgias:dba-lmdb-flags

Conversation

@Girgias
Copy link
Member

@Girgias Girgias commented Jun 29, 2022

This fixes #8856

I'm not exactly sure about the implementation for the driver flags as the way DBA is currently built the headers seem to be added somewhat magically.

These commit should also be kept separately.

@Girgias Girgias requested a review from cmb69 June 30, 2022 12:14
cmb69
cmb69 reviewed Jul 4, 2022
View reviewed changes
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! However, I don't like to introduce DBA_LMDB_USE_SUB_DIR; after all, this is a flags parameter, and as such a bitmask. Passing 0 should be sufficient, shouldn't it?

@Girgias
Copy link
Member Author

Girgias commented Jul 21, 2022

I think the reason why I added the constant is that the default would not be 0 and it feels a bit weird, but I can remove it

@cmb69
Copy link
Member

cmb69 commented Jul 21, 2022

Yeah, I see your point. It is unfortunate, that we started with MDB_NOSUBDIR as default. Maybe keep DBA_LMDB_USE_SUB_DIR.

@Girgias
Copy link
Member Author

Girgias commented Jul 22, 2022

@kocsismate why am I getting an:

In ./ext/dba/dba.stub.php:
Constant DBA_LMDB_NO_SUB_DIR must have a @cvalue annotation

Error? I don't understand why it needs a CVALUE annotation as the value is defined in the stubs?

@kocsismate
Copy link
Member

kocsismate commented Jul 22, 2022

why am I getting an:
In ./ext/dba/dba.stub.php:
Constant DBA_LMDB_NO_SUB_DIR must have a @cvalue annotation
Error? I don't understand why it needs a CVALUE annotation as the value is defined in the stubs?

But the value is UNKNOWN, right? UNKNOWN value means that REGISTER_*_CONSTANT() calls should use the C constant as value. If there is a proper constant value but there's no @cvalue then the former is used. If there are both, then the C constant value is used in C code, and an assertion is added that the 2 values match.

@Girgias
Copy link
Member Author

Girgias commented Jul 22, 2022

why am I getting an:
In ./ext/dba/dba.stub.php:
Constant DBA_LMDB_NO_SUB_DIR must have a @cvalue annotation
Error? I don't understand why it needs a CVALUE annotation as the value is defined in the stubs?

But the value is UNKNOWN, right? UNKNOWN value means that REGISTER_*_CONSTANT() calls should use the C constant as value. If there is a proper constant value but there's no @cvalue then the former is used. If there are both, then the C constant value is used in C code, and an assertion is added that the 2 values match.

The value is not UNKNOWN it is 0 as it's a constant I created which does not have an equivalent in C, which is why I'm confused by the error

Girgias
Girgias commented Jul 22, 2022
View reviewed changes
cmb69
cmb69 approved these changes Jul 22, 2022
View reviewed changes
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me (besides the two nits). Please add a note in NEWS and UPGRADING when merging.

@Girgias
Add support to pass driver flags to DBA handlers
5b891bb 
Currently only LMDB with DBA_LMDB_USE_SUB_DIR/DBA_LMDB_NO_SUB_DIR are supported
@Girgias Girgias merged commit 3c37290 into php:master Jul 23, 2022
@Girgias Girgias deleted the dba-lmdb-flags branch July 23, 2022 17:38
@saundefined saundefined mentioned this pull request Sep 12, 2022
Merged
@jrfnl jrfnl mentioned this pull request Aug 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kocsismate kocsismate kocsismate left review comments

@cmb69 cmb69 cmb69 approved these changes

Assignees

No one assigned

Labels

Extension: dba

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

dba: lmdb: allow to override the MDB_NOSUBDIR flag

3 participants

@Girgias @cmb69 @kocsismate