Seems ok to me.

Can you please open a bug to link this change with.

Having a unit test will also be appreciated

Okay so this fix doesn't actually work.

The reason is that the warning is emitted in fpm_conf_process_all_pools(), which is called in fpm_conf_post_process(), which is called in fpm_conf_init_main(), which is called right before fpm_unix_init_main().

I propose to move the call to zlog_init(fpm_globals.log_level) from fpm_unix_init_main() to fpm_conf_post_process() right after line 1161:

fpm_globals.log_level = fpm_global_config.log_level;

Does that sound reasonable, @remicollet ?

Alternatively, leave it in both places. Either way this kind of renders the other (already merged) PR obsolete, but no harm done I guess.

Or should I re-open that other PR with an amended fix, and we leave this one here separate? Harder to test and merge though. Please advise.

Best way is to provide all needed changes in this PR (the other is merged/closed)

Yup, just saying that this change moves the location of where zlog_set_level() is called yet again, so the other PR is technically redundant.

PR updated with newly moved zlog_set_level() call and a test

Ticket: https://bugs.php.net/bug.php?id=68458

Comment on behalf of remi at php.net:

merged

Thanks for your contribution.

Thanks @remicollet. I was wondering the same about the tests (have one in warning level and one in notice) and meant to ask you if I should do that but forgot :)

Could you also merge this to PHP-5.5 please, like the other change? Thanks @remicollet!

Merging in 5.5 is not possible for test (rely on -O which is 5.6+)
But will think about the code changes...
But we already have so much change in fpm.... :(

http://news.php.net/php.internals/79026