Fix bug #68532: convert.base64-encode omits padding bytes#936
Closed
mcq8 wants to merge 1 commit intophp:masterfrom
mcq8:master
Closed
Fix bug #68532: convert.base64-encode omits padding bytes#936mcq8 wants to merge 1 commit intophp:masterfrom mcq8:master
mcq8 wants to merge 1 commit intophp:masterfrom
mcq8:master
Conversation
Contributor
Author
|
Can someone with write access rerun travis CI? |
Member
|
This has been merged against 5.5 and up |
Contributor
|
Before this bugfix, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The memory stream will now read as much as possible and only set the EOF when you try to read when there is nothing left.
This is the way file streams do it and apparently some filter algorithms as convert.base64-encode depend on it.