Fix oci8/pdo_oci random test failures when run in parallel#9424
Closed
mvorisek wants to merge 1 commit intophp:PHP-8.0from
Closed
Fix oci8/pdo_oci random test failures when run in parallel#9424mvorisek wants to merge 1 commit intophp:PHP-8.0from
mvorisek wants to merge 1 commit intophp:PHP-8.0from
Conversation
Member
|
Thank you! |
Contributor
Author
|
One off topic question, why are the tests /w opcache by about 40% slower?
I would expect them to be about the same or faster. |
Member
I assume that is due to OPcache overhead, which may not pay off for a single test run. |
Contributor
Author
|
But that is brutal! Someone should probably look into the startup opcache delay, as the tests are usually very simple, so there should be minimal per initial code analysis overhead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #8348 (comment)
I seached
CREATEin theext/oci8/testsdirectory and almost all tests are conflicting (using the same name). This solution using aCONFLICTSfile seems to be used also in other ext tests directories likemysql.