Fix GH-9139: Allow FFI in opcache.preload when opcache.preload_user=root#9473
Merged
arnaud-lb merged 1 commit intophp:masterfrom Sep 9, 2022
Merged
Fix GH-9139: Allow FFI in opcache.preload when opcache.preload_user=root#9473arnaud-lb merged 1 commit intophp:masterfrom
arnaud-lb merged 1 commit intophp:masterfrom
Conversation
iluuu1994
reviewed
Sep 4, 2022
Member
iluuu1994
left a comment
iluuu1994
left a comment
There was a problem hiding this comment.
The implementation looks good, although I don't know enough about this code to understand if there are any implications here. Note that the documentation will need to be adjusted.
https://www.php.net/manual/en/opcache.preloading.php
-Running preloading as root is not allowed.
+Running preloading as root is disallowed by default. Set `opcache.preload_user=root` to explicitly allow it.Or something along those lines.
dstogov
approved these changes
Sep 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
opcache.preloadcan not be used for FFI preloading when running as root, because of a chain of causes:opcache.preloadrequiresopcache.preload_userwhen running as rootopcache.preload_useris defined, because the preloading happens in a sub-process in this caseIt is not strictly necessary to preload in a sub-process when
opcache.preload_useris the current user, because we are not going to change the uid of the process.This PR skips the fork() when
opcache.preload_useris the current user, thus allowing FFI inopcache.preloadwhen running as root, as long asopcache.preload_user=root.Although running as root is not recommended, it is common practice with docker containers. This change also allows to have at least one CI pipeline running as root.
Fixes #9139
Most changes are whitespaces.