Fixes #66764 - configure doesn't define EXPANDED_DATADIR / PHP_DATADIR correctly#975
Merged
php-pulls merged 1 commit intophp:PHP-5.5from Jan 5, 2015
Merged
Fixes #66764 - configure doesn't define EXPANDED_DATADIR / PHP_DATADIR correctly#975php-pulls merged 1 commit intophp:PHP-5.5from
php-pulls merged 1 commit intophp:PHP-5.5from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as the bugreport explains the value for EXPANDED_DATADIR doesn't gets properly expanded.
it is borked since 5.4 when we moved from autoconf 2.13 to 2.59: http://3v4l.org/IpcgT
the reason is that there are some autoconf default values which were changed in autoconf 2.59c(http://lists.gnu.org/archive/html/automake/2006-04/msg00065.html) and datadir is now defaults to '$datarootdir' which in turn defaults to '${prefix}/share'
previously(before autoconf 2.59 so up to php 5.3 there was no datarootdir and datadir was defaulting to '${prefix}/share' so a single eval was enough to expand the path.