Skip to content

GC fiber unfinished executions#9810

Merged
arnaud-lb merged 1 commit intophp:PHP-8.1from
arnaud-lb:gh9735
Jan 13, 2023
Merged

GC fiber unfinished executions#9810
arnaud-lb merged 1 commit intophp:PHP-8.1from
arnaud-lb:gh9735

Conversation

@arnaud-lb
Copy link
Member

@arnaud-lb arnaud-lb commented Oct 22, 2022 •
edited
Loading

Fixes #9735

arnaud-lb
arnaud-lb commented Oct 22, 2022
View reviewed changes
@arnaud-lb arnaud-lb mentioned this pull request Oct 22, 2022
Merged
@arnaud-lb arnaud-lb force-pushed the gh9735 branch 2 times, most recently from af9443f to 6c72d50 Compare October 22, 2022 13:23
@arnaud-lb arnaud-lb marked this pull request as ready for review November 11, 2022 16:23
@arnaud-lb arnaud-lb requested review from dstogov and trowski November 19, 2022 12:12
dstogov
dstogov approved these changes Nov 21, 2022
View reviewed changes
Copy link
Member

@dstogov dstogov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't object.

Unfortunately, this GC part becomes too complex and actually makes the idea of backup cycle collection completely inefficient. Classic mark-and-sweep GC might win now.

trowski
trowski approved these changes Nov 23, 2022
View reviewed changes
Copy link
Member

@trowski trowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on my limited knowledge of the GC this looks good. Thanks for tackling this issue!

@arnaud-lb
Copy link
Member Author

arnaud-lb commented Nov 25, 2022

Unfortunately, this GC part becomes too complex and actually makes the idea of backup cycle collection completely inefficient.

Because it increases the size of the graph, right? or because of the get_gc handler overhead?

Classic mark-and-sweep GC might win now.

Classic mark-and-sweep would make destructor execution non deterministic though

@dstogov
Copy link
Member

dstogov commented Nov 28, 2022

Unfortunately, this GC part becomes too complex and actually makes the idea of backup cycle collection completely inefficient.

Because it increases the size of the graph, right? or because of the get_gc handler overhead?

Because get_gc handler starts to copy stack slots to GC buffer. That is very similar to "mark roots" phase of mark-and-sweep.

Classic mark-and-sweep GC might win now.

Classic mark-and-sweep would make destructor execution non deterministic though

I know. Destructors and GC are conceptually incompatible.

@arnaud-lb arnaud-lb merged commit 4fb1493 into php:PHP-8.1 Jan 13, 2023
arnaud-lb added a commit that referenced this pull request Jan 13, 2023
@arnaud-lb
Merge branch 'PHP-8.1' into PHP-8.2
d894080 
* PHP-8.1:
  Reduce HT_MAX_SIZE to account for the max load factor of 0.5 (#10242)
  GC fiber unfinished executions (#9810)
arnaud-lb added a commit that referenced this pull request Jan 13, 2023
@arnaud-lb
Merge branch 'PHP-8.2'
ba091ab 
* PHP-8.2:
  [ci skip] NEWS
  Reduce HT_MAX_SIZE to account for the max load factor of 0.5 (#10242)
  GC fiber unfinished executions (#9810)
@arnaud-lb arnaud-lb mentioned this pull request Jan 13, 2023
Closed
@danog danog mentioned this pull request Feb 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@trowski trowski trowski approved these changes

@dstogov dstogov dstogov approved these changes

Assignees

No one assigned

Labels

Category: GC

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@arnaud-lb @dstogov @trowski