Fix bug #80669: FPM numeric user fails to set groups#9983
Closed
bukka wants to merge 1 commit intophp:PHP-8.2from
Closed
Fix bug #80669: FPM numeric user fails to set groups#9983bukka wants to merge 1 commit intophp:PHP-8.2from
bukka wants to merge 1 commit intophp:PHP-8.2from
Conversation
Member
Author
|
Merged via 94702c5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes issue with not setting groups when user is set using UID. It basically makes it work in the same way like setting user name if the user exists during initialization. In addition it also sets the group ID if
groupis not specified which currently defaults to 0 (root) and works only if FPM is started with--allow-to-run-as-root. Even though the current behaviour is not desirable, there is small chance that someone could rely on this. For that reason it seems more reasonable to merge this bug fix only to PHP-8.2.