The selection box will now show the current type of Bug#23
Closed
Runster wants to merge 1 commit intophp:masterfrom
Runster:stats
Closed
The selection box will now show the current type of Bug#23Runster wants to merge 1 commit intophp:masterfrom Runster:stats
Runster wants to merge 1 commit intophp:masterfrom
Runster:stats
Conversation
php-pulls
pushed a commit
that referenced
this pull request
Dec 12, 2016
Committer's note: I rewrote this from the original PR at #23 for three reasons: 1. The preceeding code usually case folded $current, but may not depending on the value of $all and $current. This was likely the source of the original issue being addressed. By using strcasecmp(), the comparison no longer cares about case. 2. While $bug_types is *probably* safe to output unescaped, it makes sense to be defensive and add some output protection. 3. Readability -Sara
|
Comment on behalf of pollita at php.net: Pushed as 21f5fd3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I've fixed a small bug:
The current bug type will be displayed after changing the select box (stats.php).