Added a confirm prompt to Subscribe/Unsubscribe button#86
Closed
staabm wants to merge 1 commit intophp:masterfrom
Closed
Added a confirm prompt to Subscribe/Unsubscribe button#86staabm wants to merge 1 commit intophp:masterfrom
staabm wants to merge 1 commit intophp:masterfrom
Conversation
Before this change a already typed comment would be lost easily when accidally pushing one of the 'Subscribe' or 'Unsubscribe' buttons. After this change a additional prompt will show up, when the comment-textarea is not empty at the time you click 'Subscribe' or 'Unsubscribe'. When the textarea is empty no prompt is shown and everything works like before
staabm
commented
Apr 20, 2020
| <td class="form-input"> | ||
| <input type="submit" name="subscribe_to_bug" value="Subscribe"> | ||
| <input type="submit" name="unsubscribe_to_bug" value="Unsubscribe"> | ||
| <input type="submit" name="subscribe_to_bug" value="Subscribe" onclick="if (document.querySelector('[name=ncomment]').value.length) return confirm('You will lose your typed comment, when subscribe. proceed?');"> |
Author
There was a problem hiding this comment.
I am open for improvements to this message
Author
|
any input on this UX improvement? its really frustrating to loose all typend content when clicking the 'wrong button' by mistake |
Contributor
|
I think the real problem is that the subscribe/unsubscribe buttons should not be in the "add comment" tab. It happened to me too. |
Member
|
Hmm, would this change still make sense given that the old bug tracker does no longer allow new reports? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the past I lost my changes several times, because after typing in the wrong captcha and a site-reload I used the wrong button to submit the form.
Before this change a already typed comment would be lost easily when accidally pushing
one of the 'Subscribe' or 'Unsubscribe' buttons.
After this change a additional prompt will show up, when the comment-textarea is not empty at the time you click 'Subscribe' or 'Unsubscribe'.
When the textarea is empty no prompt is shown and everything works like before