This repository was archived by the owner on Aug 6, 2024. It is now read-only.
Closed
Conversation
If a PGO build is requested, but a build error occurs after the PGI build has succeeded and before the PGO build has even been attempted (for instance, if the PGO training fails), we may get a bogus archive containing the PGI build, without any hint. We apply a quick fix which requires to run the PGO build if requested, and reports a respective error otherwise.
If the PGI build failed, it makes no sense to do the PGO build. If the binaries couldn't be built, it makes no sense to create the archive.
Member
Author
|
This patch is in use for our master snapshot builds for several months without any noticeable issues, so I've applied this as 296b18b. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a PGO build is requested, but a build error occurs after the PGI
build has succeeded and before the PGO build has even been attempted
(for instance, if the PGO training fails), we may get a bogus archive
containing the PGI build, without any hint. We apply a quick fix which
requires to run the PGO build if requested, and reports a respective
error otherwise.