Skip to content

Hide vote choices for in-progress votes#1

Merged
php-pulls merged 1 commit intophp:masterfrom
salathe:salathe/hide-votes-in-progress
Jan 4, 2014
Merged

Hide vote choices for in-progress votes#1
php-pulls merged 1 commit intophp:masterfrom
salathe:salathe/hide-votes-in-progress

Conversation

@salathe
Copy link
Contributor

@salathe salathe commented Sep 8, 2012 

<@ekneuss> can't we hide votes until voting phase is over ?
<@salathe> I don't see why not
<@Felipe>  just have to patch the voting module :p

This PR implements the suggestion above, to hide the choices that people made while a vote is in progress. A voter can see their own choice, but no-one else's.

After voting closes, the normal behaviour is resumed; showing all votes.

Poll with votes hidden

@php-pulls
Copy link

php-pulls commented May 8, 2013

Comment on behalf of johannes at php.net:

test. ignore.

@bjori
Copy link
Member

bjori commented Dec 31, 2013

Seriously. A year?
I guess I'll have to check PRs more frequently..

The patch no longer applies though.. Do you mind updating it?

@salathe
Copy link
Contributor Author

salathe commented Jan 3, 2014

I have reapplied the patch against current master. (I'm on the train and can't test it, but everything should be a-okay) /cc @bjori

bjori added a commit that referenced this pull request Jan 4, 2014
@bjori
Merge pull request #1 from salathe/salathe/hide-votes-in-progress
1baa226 
Hide vote choices for in-progress votes

* salathe/salathe/hide-votes-in-progress:
  Hide vote choices for in-progress votes
@php-pulls php-pulls merged commit 2c8876d into php:master Jan 4, 2014
@salathe salathe deleted the salathe/hide-votes-in-progress branch January 4, 2014 23:31
bjori added a commit that referenced this pull request Jan 7, 2014
@bjori
Revert "Merge pull request #1 from salathe/salathe/hide-votes-in-prog…
19ca75a 
…ress"

This reverts commit 1baa226, reversing
changes made to 571d084.
bjori added a commit that referenced this pull request Jan 7, 2014
@bjori
Merge branch 'revert-hide-votes'
58d29e8 
Couple of people really did not like this

* revert-hide-votes:
  Revert "Merge pull request #1 from salathe/salathe/hide-votes-in-progress"
  Revert "fix showing your vote"
@ppKrauss
Copy link

ppKrauss commented May 2, 2019

The site https://wiki.php.net/rfc/ is important for the PHP community, but there is a barrier to full-community participation (to vote and to make corrections in draft RFCs):
  The site is not offering options to "de facto standard" (or OpenID) login.

... How to submit the suggestion, to offer standard login options?

@Tyrael
Copy link
Contributor

Tyrael commented May 2, 2019

@ppKrauss that has nothing to do with this PR. check out https://wiki.php.net/rfc/voting not everybody is allowed to vote and making corrections towards other people RFCs without discussing it first is both wrong and rude.
check out https://www.php.net/git-php.php if you want to start contributing to the php project which in turn can result in a php.net account and the privilege of voting.

@ppKrauss ppKrauss mentioned this pull request May 2, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@salathe @php-pulls @bjori @ppKrauss @Tyrael