Replace Collection with GenericType#238
Conversation
jaapio
left a comment
jaapio
left a comment
There was a problem hiding this comment.
Thanks for looking into this, this is a very nice start.I think we are nearly there. Some small suggestions regarding naming and typing. And one bigger concern.
For example self<TValue>. The value between the <> can be resolved, but when it is a Object we should translate it to a new type, GenericTemplate as we can not know for sure whether TValue is a class in the current namespace or a template value. TemplateValue will be a new Type so it will fit into your current implementation. Maybe we can pass the FQEN that we resolved in the construction of the Generic like you do now. So we can expose this information to our users in a method like getResolvedType?
This way we never do false assumptions. But still provide all info we have
|
Thanks for your valuable comments. Then I will implement the template type here. I like your idea. |
|
It seems to be looking good now. Please take a look :) |
|
Awesome! Thanks for this. I changed the target branch to the new 2.x branch. This is good to be merged. It will take some time to have v2 ready as I want to remove some old legacy from the code base. |
2 participants
If I understand everything correctly, it should look something like this :)
I suggest adding a Value Object for the template type in a separate request.