ForceSSL fix see bug #3510196#13
Closed
mlr wants to merge 2 commits intophpmyadmin:masterfrom
mlr:forcessl-bug
Closed
ForceSSL fix see bug #3510196#13mlr wants to merge 2 commits intophpmyadmin:masterfrom mlr:forcessl-bug
mlr wants to merge 2 commits intophpmyadmin:masterfrom
mlr:forcessl-bug
Conversation
Contributor
|
The preg_replace you wrote will badly fail in case IPv6 address is used. Also please try to honor coding style. |
ghost
assigned
Author
|
Ah. You're right of course, hadn't thought about that. Thanks for your feedback though, I'll work on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request addresses the following bug:
http://sourceforge.net/tracker/?func=detail&aid=3510196&group_id=23067&atid=377408
The two commenters disagree that it is a PHPMyAdmin issue, however I do not agree. The OP's bug report is valid if you consider the fact that users can configure their server to run on a non-standard SSL port. If you have set the PmaAbsoluteUri and reference the non-standard port number in that address, then phpMyAdmin will not use that port when ForceSSL is set to true. This is addressed by keeping the port number in the URL when redirecting to SSL if it exists in PmaAbsoluteUri.
There is also a new config setting available called SSLPort. If that is set, phpMyAdmin will redirect to that port number, otherwise the standard SSL port of 443 will be used.