Skip to content

Fix failing tests#20225

Merged
MauricioFauth merged 1 commit intophpmyadmin:masterfrom
MauricioFauth:controllers-tests
Mar 7, 2026
Merged

Fix failing tests#20225
MauricioFauth merged 1 commit intophpmyadmin:masterfrom
MauricioFauth:controllers-tests

Conversation

@MauricioFauth
Copy link
Member

@MauricioFauth MauricioFauth commented Mar 7, 2026

Signed-off-by: Maurício Meneghini Fauth <[email protected]>
Comment on lines +7199 to +7202
<PossiblyUnusedReturnValue>
<code><![CDATA[bool]]></code>
<code><![CDATA[bool]]></code>
</PossiblyUnusedReturnValue>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where did this come from?

Copy link
Contributor

@liviuconcioiu liviuconcioiu Mar 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's from this this 7b759b4, which got removed in 1cb42fd

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add by 7b759b4 and removed by 1cb42fd.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I saw that but I am wondering why is it added back? When I run psalm it doesn't try to add these baseline entries.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I had to execute it with --no-cache

@MauricioFauth MauricioFauth merged commit 2e8bd9e into phpmyadmin:master Mar 7, 2026
43 checks passed
@MauricioFauth MauricioFauth deleted the controllers-tests branch March 7, 2026 17:50
@MauricioFauth MauricioFauth self-assigned this Mar 7, 2026
@MauricioFauth MauricioFauth added this to the 6.0.0 milestone Mar 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants