WDYT of this small fix @staabm @ondrejmirtes ?
I'll need it to fix #4435 after

• 99% operation ~ are on small number

I am not sure this argument makes sense, since as far as I understand it ~1 already returns a different result on 64 bit vs. 32 bit PHP.

I think we need to either judge whether...

• 32 bit php is still worth supporting (maybe worth dropping with PHPStan 3.x)
• whether this more precise types should be bleeding edge only (or otherwise feature flagged)

• 99% operation ~ are on small number

I am not sure this argument makes sense, since as far as I understand it ~1 already returns a different result on 64 bit vs. 32 bit PHP.

When I tried I got ~n = -(n+1) and it does not depends on the PHP bit size (for small numbers).
You can try, ~1 returns -2 in both 32 and 64 bit PHP.

Thank you.

Either this or #4435 is a reason for a new error:

				$previousErrorHandler = set_error_handler(
					function (int $severity, string $message, string $file, int $line) use ($item, $columnIndex, $rowIndex, $startRowIndex, &$previousErrorHandler): mixed {
						if (($severity & E_WARNING | E_NOTICE) > 0) {
							$this->throwInvalidValueException($item, $this->columns[$columnIndex], $rowIndex - $startRowIndex, $columnIndex);
						} elseif ($previousErrorHandler !== null) {
							return $previousErrorHandler($severity, $message, $file, $line);
						}

						throw new ShouldNotHappenException(sprintf('Unexpected error %s: %s', $severity, $message));
					},
				);

  117    Comparison operation ">" between 8|9|10 and 0 is always true.  
         🪪  greater.alwaysTrue                                         
  123    Unreachable statement - code above always terminates.          
         🪪  deadCode.unreachable                                       

Do you think it's valid or not? I suspect the code should be parenthesized like this $severity & (E_WARNING | E_NOTICE) but not sure.

Were does come from this error ? I don't see such code in phpstan codebase.

Do you think it's valid or not? I suspect the code should be parenthesized like this $severity & (E_WARNING | E_NOTICE) but not sure.

This seems valid to me, I think it should be $severity & (E_WARNING | E_NOTICE)

Each commit to PHPStan is analysed on four private projects only I have access to.

I think it should be $severity & (E_WARNING | E_NOTICE)

agree