Fix ArrayCountValuesDynamicReturnTypeExtension#4618
Merged
ondrejmirtes merged 2 commits intophpstan:2.1.xfrom Jan 20, 2026
Merged
Fix ArrayCountValuesDynamicReturnTypeExtension#4618ondrejmirtes merged 2 commits intophpstan:2.1.xfrom
ondrejmirtes merged 2 commits intophpstan:2.1.xfrom
Conversation
Contributor
|
Looks like it should be $allowedValues->isSuperTypeOf(...) |
Contributor
Author
How you deal with something like "int|null" ? |
Contributor
|
I see now, that you also need the normalized result. its not just a check for compatibility. my suggestion did not fit that. |
Contributor
|
good catches, didn't think to try other scalar types 👍 |
793506d to
e4c6f83
Compare
e4c6f83 to
8c5e211
Compare
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
$type->toArrayKey() instanceof ErrorTypeis not the right check causetrue, false, 1.0, null, ...are ignored by the function. It has to be an int or a string.And numeric string wasn't casted into int when used as array key.