Fix get defined vars return type#4632
Merged
VincentLanglet merged 1 commit intophpstan:2.1.xfrom Feb 9, 2026
Merged
Conversation
0501de2 to
43ebc5e
Compare
Collaborator
|
This pull request has been marked as ready for review. |
43ebc5e to
109e9d2
Compare
staabm
reviewed
Feb 9, 2026
| $typeBuilder = ConstantArrayTypeBuilder::createEmpty(); | ||
|
|
||
| foreach ($scope->getDefinedVariables() as $variable) { | ||
| if ($variable === 'this') { |
Contributor
There was a problem hiding this comment.
just double checked: since regular variables cannot be named '$this' we don't need a inClassScope or similar check
its a open feature request that we don't error about such case atm: phpstan/phpstan#3585
Contributor
There was a problem hiding this comment.
I also though about moving this check directly into $scope->getDefinedVariables() but I would not do that because there might be extensions out there which depend on the behaviour that '$this' is returned atm
staabm
approved these changes
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes phpstan/phpstan#13881