ConstantStringType: Prevent creation of unnecessary constant-object types#4696
Merged
ondrejmirtes merged 1 commit intophpstan:2.1.xfrom Jan 2, 2026
Merged
ConstantStringType: Prevent creation of unnecessary constant-object types#4696ondrejmirtes merged 1 commit intophpstan:2.1.xfrom
ondrejmirtes merged 1 commit intophpstan:2.1.xfrom
Conversation
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
before this PR most constant-string key types contained the same constant type again, which represents the php auto converted array-key variant.
I don't think we should hold 2 objects per constant string type which is used as array key.