NodeDependencies: cache normalized filenames#4815
Merged
ondrejmirtes merged 5 commits intophpstan:2.1.xfrom Jan 24, 2026
Merged
NodeDependencies: cache normalized filenames#4815ondrejmirtes merged 5 commits intophpstan:2.1.xfrom
ondrejmirtes merged 5 commits intophpstan:2.1.xfrom
Conversation
Member
|
Can you experiment with having the cache in FileHelper directly? |
Contributor
Author
|
great idea. moving the cache to FileHelper makes the number of non-cached invocations drop to 11.623 in phpstan-src |
Contributor
Author
|
just double checked: after this PR 
|
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in shopware, in which we have a lot of shared traits, the same paths are over and over again normalized.
we can see
FileHelper::normalizePathtake ~41 seconds, from which 95% are called fromNodeDependencies::getFileDependencies.even running this PR on phpstan-src, I can see
FileHelper::normalizePathdropping from 175.059 to 137.958