Fix while-true-if-break: Variable might not be defined#5118
Merged
VincentLanglet merged 6 commits intophpstan:2.1.xfrom Mar 3, 2026
Merged
Fix while-true-if-break: Variable might not be defined#5118VincentLanglet merged 6 commits intophpstan:2.1.xfrom
VincentLanglet merged 6 commits intophpstan:2.1.xfrom
Conversation
VincentLanglet
commented
Mar 1, 2026
| $this->checkMaybeUndefinedVariables = true; | ||
| $this->polluteScopeWithAlwaysIterableForeach = true; | ||
|
|
||
| $this->analyse([__DIR__ . '/data/bug-11545.php'], []); |
Contributor
Author
There was a problem hiding this comment.
This currently does not work because of
https://phpstan.org/r/cd248edd-5252-4bba-ada5-26cce593585b
staabm
reviewed
Mar 2, 2026
- In while(true) loops, the only way to exit is via break, so the post-loop scope should be constructed solely from break exit point scopes - Previously, break scopes were merged with the "normal exit" scope (filterByFalseyValue), which degraded variable certainty to "maybe" for variables only defined in the break path - New regression test in tests/PHPStan/Rules/Variables/data/bug-9023.php Closes phpstan/phpstan#9023
Collaborator
|
This pull request has been marked as ready for review. |
staabm
approved these changes
Mar 3, 2026
This was referenced Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cf #4959
Closes phpstan/phpstan#11545
Closes phpstan/phpstan#10245
Closes phpstan/phpstan#11984
Closes phpstan/phpstan#5477
Closes phpstan/phpstan#5919
Closes phpstan/phpstan#9023