Fix phpstan/phpstan#13799: false positive on in_array(...) check with impure second argument#5141
Merged
VincentLanglet merged 2 commits intophpstan:2.1.xfrom Mar 8, 2026
Conversation
- For non-constant arrays that might be empty (isIterableAtLeastOnce is not yes), return null (indeterminate) when the needle type is compatible with the haystack value type, since the array could be empty making in_array return false - Still correctly reports "always false" when needle type is incompatible with haystack value type regardless of array emptiness - Added regression test for the reported issue Closes phpstan/phpstan#13799
VincentLanglet
approved these changes
Mar 7, 2026
staabm
approved these changes
Mar 8, 2026
uekann
pushed a commit
to uekann/phpstan-src
that referenced
this pull request
Mar 9, 2026
…th impure second argument (phpstan#5141) Co-authored-by: VincentLanglet <[email protected]> Co-authored-by: Vincent Langlet <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes phpstan/phpstan#13799