Fix formatting of incomplete CSS value comments#16583
Merged
fisker merged 7 commits intoprettier:mainfrom Oct 10, 2024
Merged
Conversation
Member
|
This doesn't fix the problem, Prettier pr-16583 --parser cssInput: h1 {
--OFF: /* OFF */;
--OFF: /* OFF */;
--OFF: /* OFF */;
--OFF: /* OFF */;
--OFF: /* OFF */;
--OFF: /* OFF */;
}Output: h1 {
--OFF: /* /* OFF * */;
--OFF: /* /* OFF */;
--OFF: /* /* OFF */;
--OFF: /* /* OF */;
--OFF: /* /* O */;
--OFF: /* /* */;
} |
Member
|
I'll take a look. |
fisker
reviewed
Aug 23, 2024
| --OFF: /* OFF */; | ||
| --OFF: /* OFF */; | ||
| --OFF: /* OFF */; | ||
| --OFF: /* OFF */; |
Member
There was a problem hiding this comment.
I can't find specs for how this should work, not sure if it can be removed.
4 tasks
Member
|
@sosukesuzuki Can you take a look? |
sosukesuzuki
commented
Oct 9, 2024
Contributor
Author
sosukesuzuki
left a comment
sosukesuzuki
left a comment
There was a problem hiding this comment.
This is my PR so I cannot approve it on GitHub, but LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #15948
This is a non-ideal workaround, because it's a parser bug.
Checklist
changelog_unreleased/*/XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.✨Try the playground for this PR✨